Paul Fultz II

Results 392 comments of Paul Fultz II

Can you write a `get_matcher` function to wrap the matcher to skip dynamic shapes: ```cpp MIGRAPHX_PRED_MATCHER(not_dynamic_shape, instruction_ref ins) { return not ins->get_shape().dynamic(); } template auto get_matcher(const Finder& f) { if...

@copilot This should use another finder struct and not the attention finder. It should run after running `find_attention`, it should look for the `group[tag=attention]` operator(not a flash decoding operator that...

@copilot Please fix the CI failures.

@copilot Please fix the CI failures.

It seems like separating these in seperate classes causes a lot of duplication. I would prefer we write these operators using smaller reusable op builders here. There should be an...

Unit tests need to be added for fusing the pointwise modules. You will need to add a test suite for the `fuse_pointwise_reduce` pass and add a test there. The `is_dependent`...

> Running fuse_pointwise in one of the simplify_algebra tests. Any difference with moving to fuse_pointwise_reduce? Sorry I missed, that should be fine in the simplify_algebra tests.

We would need support for pkgconfig in hip first before it could be implemented in miopen. Also, any generation of pkgconfig files needs to be done by rocm-cmake to ensure...

Right now there isnt an easy way to do this. If we skip attention in fuse_mlir there will be left over `group` op that wont get lowered. We probably need...

Can you post the data as a comma separated list or a link to the spreadsheet online?