Patrick Fulton

icon indicating a website link http://www.patrickfulton.net

icon company @adobe icon location Pittsburgh, PA icon location Design system engineer/web dev, secret punk person, and dog owner. Also: co-organizer of Refresh Pittsburgh.

Results 141 comments of Patrick Fulton

fix(rating): address inconsistent hover behavior

Marking this as `blocked` for now until we get S2 Foundations merged into `main`. Once we do, we'll come back to this, get it rebased against the new `main` stuff,...

`spectrum-Menu-item` label alignment subject to cascade of text-align CSS property

@Rocss thanks for following up with us on this. With regard to what @lazd mentioned: > ...the Overlay V2 changes since overlays being inserted adjacent to the trigger. This bug...

fix: correct the display of checkbox read-only state

@jawinn Just need you to talk a look at the Chromatic changes here. Once those are good to go, we can merge!

feat: use storybook v8

@castastrophe Interesting that the PR deployed docs site link above doesn't include the link to Storybook.

[Coachmark][a11y]: subtle animation should support prefers-reduced-motion media query

@majornista thank you! We're actively working to migrate this component to the new Spectrum Tokens system, and @jenndiaz is working on it in our current sprint. I added a note...

[Coachmark][a11y]: subtle animation should support prefers-reduced-motion media query

@majornista any additional thoughts here with regard to @jenndiaz's comment [above](https://github.com/adobe/spectrum-css/issues/1952#issuecomment-1601674798)? We're getting close to merging and releasing this component and want to be sure that we've addressed everything.

[Popover] Unreasonable complex selectors with duplicate classes generated

Tracking this in Jira via [CSS-750](https://jira.corp.adobe.com/browse/CSS-750)

Color Handle delivery sensitive to CSS inclusion order.

Tracking this in Jira here: https://jira.corp.adobe.com/browse/CSS-587

[Tokens] Value in "Spectrum" theme missing in "Express" theme

Tracking this in Jira here: https://jira.corp.adobe.com/browse/CSS-595

hyphen:auto can cause unexpected character wrapping

Thanks @yloubry! We're tracking this in Jira here: https://jira.corp.adobe.com/browse/CSS-799 - it's slated to be worked on in our next sprint which begins on Monday, June 17