mingus icon indicating copy to clipboard operation
mingus copied to clipboard

Mingus can't start after updated to emacs 28

Open xiangsheng opened this issue 2 years ago • 6 comments

After updating to emacs 28 recently, I find mingus can't start any more and get the following error.

error in process filter: Symbol's function definition is void: _mpdgl

Especially annoying thing is that the emacs got stuck and can't respond to C-g even.

xiangsheng avatar May 03 '22 15:05 xiangsheng

If you reinstall this package and open it immediately, yes, it works. But if you restart emacs and open mingus again, it got stuck again. It seems that a library, ie libmpdee.el, mingus uses is outdated. Some macros in this library can't be evaluated automatically at startup. Someone gives me a modified libmpdee.el, with which the bug is fixed. See this link: https://pastebin.com/w0n2HXWU. It seems that we only need to add some # before some lambda functions.

Best wishes, xs

On 2022.05.05 03:11, Vincent Zhang wrote:

I can confirm it does work well on 28. Try reinstalling the package.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: <pft/mingus @.**>

xiangsheng avatar May 05 '22 12:05 xiangsheng

I got same problem. Even I delete mingus and libmpdee both, and reinstall again, and restart Emacs still got same problem.

stardiviner avatar Jun 12 '22 07:06 stardiviner

If you reinstall this package and open it immediately, yes, it works. But if you restart emacs and open mingus again, it got stuck again. It seems that a library, ie libmpdee.el, mingus uses is outdated. Some macros in this library can't be evaluated automatically at startup. Someone gives me a modified libmpdee.el, with which the bug is fixed. See this link: https://pastebin.com/w0n2HXWU. It seems that we only need to add some # before some lambda functions.

Finally got around to looking at this, now the pastebin is gone. Care to reshare @xiangsheng ?

pft avatar Jul 04 '22 06:07 pft

https://pastebin.com/a5grGz1Z @pft

xiangsheng avatar Jul 04 '22 07:07 xiangsheng

@pft I tested with https://pastebin.com/a5grGz1Z, and it's working well. Can you please integrate it instead of the deprecated libmpdee package? Or upgrade libmpdee package?

seagle0128 avatar Jul 04 '22 08:07 seagle0128

I think it may be better to integrate libmpdee into mingus, since no one seems to maintain libmpdee any more.

xiangsheng avatar Jul 04 '22 09:07 xiangsheng

I have just merged a PR which someone else raised a while on a similar issue, please try the latest version and let me know..

andyetitmoves avatar Aug 21 '22 15:08 andyetitmoves

@andyetitmoves May I know where to get the PR?

seagle0128 avatar Aug 21 '22 16:08 seagle0128

I have just merged a PR which someone else raised a while on a similar issue, please try the latest version and let me know..

Awesome. Integrating libmpdee was something I wasn't keen on doing. This indeed should fix it, since it's functionally equivalent to the shared patch.

@seagle0128 it's a PR for libmpdee.

pft avatar Aug 21 '22 16:08 pft

Note: when installing from melpa, I had to remove the cached version in order to update to the new libmpdee.

pft avatar Aug 25 '22 08:08 pft

Hmm, on that cached thing: mingus has

;; Package-Requires: ((libmpdee "2.1"))

I think it'd be better if @andyetitmoves updated the version number of libmpdee and mingus updated the Package-Requires line.

pft avatar Aug 25 '22 09:08 pft

Created in issue for that: https://github.com/andyetitmoves/libmpdee/issues/9

pft avatar Aug 25 '22 09:08 pft

Now bumped up to 2.2.

On Thu, 25 Aug 2022 at 10:42, Niels Giesen @.***> wrote:

Created in issue for that: andyetitmoves/libmpdee#9 https://github.com/andyetitmoves/libmpdee/issues/9

— Reply to this email directly, view it on GitHub https://github.com/pft/mingus/issues/39#issuecomment-1227029155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOXWPLA7CZPNQ2BSAIE5RLV245XHANCNFSM5U7F5IEQ . You are receiving this because you were mentioned.Message ID: @.***>

andyetitmoves avatar Aug 25 '22 09:08 andyetitmoves

Thanks, I also bumped the dependency now.

pft avatar Aug 25 '22 10:08 pft

It is quite pleasant to see people are maintaining the old packages. That makes emacs a lovely place to play around. Thanks, @pft and @andyetitmoves .

xiangsheng avatar Aug 25 '22 13:08 xiangsheng