pfsense icon indicating copy to clipboard operation
pfsense copied to clipboard

remove line filename from the pool section

Open jzadir opened this issue 3 years ago • 3 comments

Remove the filename config single line as it breaks the conditional dhcp config for pxe;

  • [x] Redmine Issue: https://redmine.pfsense.org/issues/12986
  • [x] Ready for review

jzadir avatar Apr 26 '22 22:04 jzadir

There is already a fix on that Redmine issue that should prevent that line from being a problem when it isn't needed. Is the current fix incomplete or not functional? If so, comment that on the Redmine. If you haven't tested the fix on the Redmine yet, please do so before suggesting additional changes.

jim-p avatar Apr 27 '22 12:04 jim-p

I've tested the suggested fix and it does not work; this PR is running in production and solved the issue; Looking in the history of the file I realize that the cause of the problem was a change in the logic;

jzadir avatar Apr 27 '22 13:04 jzadir

Looking in the history of the file I realize that the cause of the problem was a change in the logic;

Is a different change needed? There's likely a reason why the line was included in that case - some additional clarification here would be helpful

marcos-ng avatar Nov 01 '23 23:11 marcos-ng