coder icon indicating copy to clipboard operation
coder copied to clipboard

Published 20 hours ago • verified publisher icon pfrenssen

Incomplete attempt at @todo capitalization enforcement.

Open adamzimmermann opened this issue 2 years ago • 4 comments

This might end up being closed.

Discussion here:

  • https://git.drupalcode.org/project/drupal/-/merge_requests/504#note_119707

Issue:

  • https://www.drupal.org/i/3180696

adamzimmermann avatar Sep 19 '22 22:09 adamzimmermann

On the d.o. issue you said

My vote is to take the gains we have and move forward to begin seeing the benefits.

Yes I agree. If I can help with anything, let me know

jonathan1055 avatar Sep 20 '22 08:09 jonathan1055

Thanks, can you make an issue in the Coder issue queue? Then we can track credit and work there aside from the Drupal core issue.

klausi avatar Sep 20 '22 10:09 klausi

Yes, in response to @klausi's points above, I think the logic could be reverted to allow any non-space except "-" or ":" as we had before. Then we give a separate warning if the first letter is a lower-case alpha and provide the fix to convert to upper case.

jonathan1055 avatar Sep 20 '22 11:09 jonathan1055

I have created an issue to facilitate further discussion as requested.

  • https://www.drupal.org/project/coder/issues/3314583

I tried to summarize the consensus there, but if others could chime in with their understanding of the requirements that would be great. Then I can begin working on implementing it.

adamzimmermann avatar Oct 11 '22 01:10 adamzimmermann