Paul Frazee

Results 872 comments of Paul Frazee

Hmm! A file deletion is intended to be interpreted as a deletion of the record and the data should be unindexed. See [this code](https://github.com/beakerbrowser/webdb/blob/master/lib/indexer.js#L296). Maybe this is a bug?

Ok sounds like two bugs: 1. Indexed data got out of sync with the source data 2. Calling `.download()` on invalidate is triggering an error when the file is deleted...

Thanks but I'll write some tests and figure out how to handle download failures first

|ios feed before|after| |-|-| |![CleanShot 2024-04-04 at 15 35 29@2x](https://github.com/bluesky-social/social-app/assets/1270099/276700e2-397f-4bc8-b6df-90b5340dde20)|![CleanShot 2024-04-04 at 15 26 01@2x](https://github.com/bluesky-social/social-app/assets/1270099/6b3c2447-c8a6-4dfe-ba39-46b44dd1b8b5)| |ios thread before|after| |-|-| |![CleanShot 2024-04-04 at 15 35 51@2x](https://github.com/bluesky-social/social-app/assets/1270099/60eca65a-3e1a-4e0a-8583-b4ad891fd0ec)|![CleanShot 2024-04-04 at 15 27 12@2x](https://github.com/bluesky-social/social-app/assets/1270099/8963346d-fbf4-473c-a76a-d65c215407cc)|...

Excited for this change, but you know Imma nitpick. First two thoughts: ![CleanShot 2024-04-04 at 15 38 28@2x](https://github.com/bluesky-social/social-app/assets/1270099/106fd92c-21f4-4873-9980-e93cef61b44b) Also the icons seem slightly larger in general. I may need to...

This is something we're discussing right now. Quote posts have a habit of being pretty dunk-prone, but we're talking about a mitigation to that issue (that you can essentially unquote...

I glanced through the electron-webrtc source and nothing stood out at me, as a possible source. It's possible some code that depends on electron-webrtc (and therefore only executes when it's...

Looks good, would you mind adding some automated tests for it? Beaker has some you can use as a reference.

😅 oh right, I forgot that I haven't gotten any tests into this thing either. What a hypocrite! Yeah would you mind? ava is what I'd want to use.

Sure I'll check into it. Thanks for putting the tests together!