menoh icon indicating copy to clipboard operation
menoh copied to clipboard

add more libraries to Libs.private for static linking

Open msakai opened this issue 5 years ago • 2 comments

We need to list all privately used libraries in Libs.private for static linking to work.

Note that -lstdc++ and -lm seem to work also on macOS.

msakai avatar Feb 07 '19 05:02 msakai

Users who doesn't use mkldnn but tensorrt needn't link libmkldnn. So we need to change @MKLDNN_LIBRARY@ part depending on ENABLE_MKLDNN.

okdshin avatar Feb 07 '19 11:02 okdshin

Yes. It is desirable when ENABLE_MKLDNN flag is added to master. If it takes more time for tensorrt branch to be mature enough for merging, how about cherry-picking ENABLE_MKLDNN feature from tensorrt branch into master?

msakai avatar Feb 18 '19 06:02 msakai