passifox icon indicating copy to clipboard operation
passifox copied to clipboard

TypeError in cip.retrieveCredentialsCallback

Open zlin opened this issue 9 years ago • 2 comments
trafficstars

credentials parameter is sometimes undefined

https://github.com/pfn/passifox/blob/master/chromeipass/chromeipass.js#L1206

Error in event handler for (unknown): TypeError: Cannot read property 'length' of undefined at cip.retrieveCredentialsCallback (chrome-extension://ompiailgknfdndiefoaoiligalphfdae/chromeipass.js:1206:17) at cip.retrieveCredentialsCallback (chrome-extension://ompiailgknfdndiefoaoiligalphfdae/chromeipass.js:1206:2) (index):1 Error in event handler for (unknown): TypeError: Cannot read property 'length' of undefined at cip.retrieveCredentialsCallback (chrome-extension://ompiailgknfdndiefoaoiligalphfdae/chromeipass.js:1206:17)

zlin avatar Oct 27 '16 14:10 zlin

Seems the same here:

Error in event handler for (unknown): TypeError: Cannot read property 'length' of undefined
    at cip.retrieveCredentialsCallback (chrome-extension://ompiailgknfdndiefoaoiligalphfdae/chromeipass.js:1186:18)

Code:

cip.retrieveCredentialsCallback = function (credentials, dontAutoFillIn) {
	if (cipFields.combinations.length > 0) {
		cip.u = _f(cipFields.combinations[0].username);
		cip.p = _f(cipFields.combinations[0].password);
	}

	if (credentials.length > 0) { ////////////// THIS LINE
		cip.credentials = credentials;
		cip.prepareFieldsForCredentials(!Boolean(dontAutoFillIn));
	}
}

Extension: chromeIPass v2.8.1 KeePass version: v2.38 KeePassHttp version: also v2.38 Pages on which the error occur: all with a password field

monty241 avatar May 04 '18 06:05 monty241

Same here. This might be related to the implementation of Let's Encrypt on our staging server. Our production server does not, yet, use Let's Encrypt, and does not suffer this issue.

Will need to investigate further.

Error handling response: TypeError: Cannot read property 'length' of undefined
    at cip.retrieveCredentialsCallback (chrome-extension://ompiailgknfdndiefoaoiligalphfdae/chromeipass.js:1186:18)
chpqatest.chpqa.com/:1 Unchecked runtime.lastError: The message port closed before a response was received.

ricardoee avatar Mar 16 '19 11:03 ricardoee