Patrick Florek

Results 40 comments of Patrick Florek

@pflorek remember to remove value override for `engineInstallUrl`

Hey @Obirah , actually you can pass env vars to the runner: https://github.com/pepperize/cdk-autoscaling-gitlab-runner/blob/main/API.md#environmentoptional- Which configuration properties are missing exactly to you https://docs.gitlab.com/runner/configuration/advanced-configuration.html ? You may open a PR adding them....

Hey @Obirah , you may refactor the init config step `repositories` to be passed by the construct's props. Then you pass your own `InitConfig` to setup your private mirror. The...

Hey @nerdlem , in your mangement account obtain the `Organization.root` to use as the parent for the first OUs https://github.com/pepperize/cdk-organizations#organization

> I think someone would need to trigger the workflow, right? @pflorek @peternowee I'm not a maintainer, who is in charge?

@evanplaice @thomasdavis

Hey @lkolchin , the role name `OrganizationAccountAccessRole` is the default that will be created by the [AWS Organization API call](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Organizations.html#createAccount-property). It's used by the custom resource only as a parameter....

`lib/cluster-providers/mng-cluster-provider.ts` ```typescript export interface MngClusterProviderProps extends eks.CommonClusterOptions, Omit { ``` Maybe not to inherit props from `eks.CommonClusterOptions`. Overriding them won't work well with jsii later on

I agree with the previous issue, the generated names aren't that nice. Also it's really nice to have constructs such as `MngClusterProvider`. For a quick start they should stay opionated....

You may use https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides or https://yarnpkg.com/cli/set/resolution --- Additional in the package.json should be a version constraint like `"aws-cdk-lib": "^2.43.0",` it should be almost save to do so. To assist this...