Sebastian Pfitzner

Results 715 comments of Sebastian Pfitzner

Should be fixed with https://github.com/JunoLab/atom-ink/pull/155/commits/f32c69f851e90a03a86250ecd5210dd735baee1d, but I can't reproduce the initial example.

Juno is correctly interpreting those ANSI escape codes now, so they shouldn't show up in our output anymore. I'm not entirely sure how it's possible to figure out whether a...

Our code already tries to handle this case, but it's obviously buggy.

I'm not entirely sure I like this approach, but maybe it's necessary considering how hard it has been to fix the actual issues. Let me think about this a bit...

You need overloads for the correct `Base.show` method (see [here](http://docs.junolab.org/latest/man/info_developer/#Displaying-Plots-and-Graphics-1) for some docs on that). I didn't see *any* `Base.show` overloads in this package, so I have no idea how...

> Is it a good idea to use use width, `height = get(io, :juno_plotsize, [100, 100])` because the function might be useful outside Juno. Do you have suggestion for improvement?...

> Does VS Code evaluate stuff in a different task? Is there an API to influence that? Yes and no. We should however call the REPL ast transforms properly (although...

So is there a reason why `show` doesn't synchronize the array? Relying on the REPL hooks seems brittle, no?

It's not strictly necessary for us to do it like that. Currently we're evaluating user code in a separate task that's created purely for that purpose (so we can schedule...

Ok, so in theory we can fix this by calling `display` in the same task that evaluates the user code, but - this breaks `ans` - I don't see why...