makelove icon indicating copy to clipboard operation
makelove copied to clipboard

Permissions are now changed for custom appImages

Open pakeke-constructor opened this issue 1 year ago • 2 comments

Previously, if you had a custom appImage, the execute permission wasn't set on your AppImage.

This PR changes/fixes that

pakeke-constructor avatar Oct 02 '23 10:10 pakeke-constructor

There is a chance that the we don't have permission to add the executable bit on the custom AppImage in which case this might break for some people. This is probably (like 95%) fine, but could you add a check that the executable bit is not already set? I'd probably do if not os.access(source_appimage, os.X_OK). Would you mind adding that?

pfirsich avatar Oct 21 '23 18:10 pfirsich

Yup! sure thing. Good catch btw

pakeke-constructor avatar Oct 23 '23 09:10 pakeke-constructor