pfi79

Results 42 comments of pfi79

@takayuki-nagai let's refine the scenario: - created a genesis block - create a channel on the orderers - create a channel on peers. Did you do any other actions? -...

I want to write a test and run it in brunch main, tag v3.1.0 and brunch release-2.5, tag v2.5.12. And check if it works everywhere or not.

@mperlinesfortes does your fabric have storage in leveldb?

1. State in storage (leveldb) key-value can be retrieved or sorted only by primary key. In order to be able to sort values differently, it is necessary to create keys...

The code is similar to this test. Sometimes it works, and sometimes it doesn't. ``` func TestImageBuild(t *testing.T) { cli, err := client.New(client.FromEnv) require.NoError(t, err, "failed to get docker client")...

> > And after that, ImageInspect doesn't find the image either. He finds it only after a while. > > When `ImageBuild` returns, the build is still in progress until...

> We could make it a little bit more ergonomic by having some helpers like `Wait` implemented for the [`ImageBuildResult`](https://github.com/moby/moby/blob/06eadccf2fd03ed4aca8f467f38eb6dd7be48922/client/image_build_opts.go#L77) > > This should probably match the approach from `ImagePull`:...

> Could you post me a test that reproduces the issue? > I ran the test below x100 and it worked: This is the test. But I'm getting over it...

What for? What has been added now that the next version is needed?

> > Technically, you did the right thing, but in my opinion, it can be improved. Try to do better. > > Thanks for your review! Modified! please achieve a...