Pol Febrer Calabozo
Pol Febrer Calabozo
Also if you prefer other names for the functions I don't mind, Thomas used `composite`, I don't know which one is better.
> I think it follows naturally that each consequtive "column" in the structure needs to be of alternating type. Hence, for a given input of widths and repetitions are only...
> I like `nanoribbon_hetero`, kind of feel the "junction" is just too long. ;) But then the graphene version of it would be `graphene_nanoribbon_hetero` ? :sweat_smile:
> But that is the same as the other arguments in the Section tuple, no? Yes, it's just that the more parameters you add, the worse it gets :) Specially...
Also, for the name: It is not really a `heterojunction` but potentially several `heterojunctions`, so probably calling it `heterojunction` would not picture what the function does exactly.
Well in that case you might as well build the section object yourself instead of passing a dict :)
However would you then introduce the `open` parameter? That forces the user to replace a list with a dict just to change the configuration.
The imaginary number seems natural to me. `2j` is just `2` shifted by a phase :)
Another option could be using negative numbers (`-2` instead of `2j`)
Oooh ok I understand now, so ```python graphene_nanoribbon([(7, 2), (11, 2)], open_start=True) # or invert=True ``` would be the old ```python graphene_nanoribbon([(7, 2j), (11, 2)]) ``` ? I like it...