circuitjs1 icon indicating copy to clipboard operation
circuitjs1 copied to clipboard

[BUG] Shared Labeled Nodes Truncated to One Pin when Creating Subcircuits

Open SvarunSoda opened this issue 1 year ago • 4 comments

Attempting to create a subcircuit from a circuit which has more than one shared labeled node always results in the shared label node groupings to get truncated to a single pin on the subcircuit.

Specific example: image TEST_1.txt

When attempting to create a subcircuit from the circuit above;

  • the GND_FIRST and GND_NEXT labeled nodes get truncated into a single GND_FIRST node
  • the 3.3V_FIRST and 3.3V_NEXT labeled nodes get truncated into a single 3.3V_NEXT node
  • the OUT and DIV_NEXT labeled nodes get truncated into a single DIV_NEXT node

The subcircuit creation script appears to automatically identify & truncate any shared labeled node groupings to a single node, which is not the intuitive or expected behaviour here. In my specific case the shared labeled nodes all serve unique purposes despite being shared, and I am unable to create a subcircuit because of this feature. At least this feature should be a toggleable option.

SvarunSoda avatar Dec 22 '24 23:12 SvarunSoda

Does it help if you put a zero ohm resistor between the two nodes?

fritzw avatar Dec 23 '24 10:12 fritzw

You can't have a zero ohm resistor but a one ohm resistor should work.

pfalstad avatar Dec 23 '24 13:12 pfalstad

Thanks for the comments; putting a 1 nano-Ohm resistor does the trick there, albeit this should still ideally be a separate feature.

SvarunSoda avatar Jan 15 '25 09:01 SvarunSoda

re-opening since it should still be fixed.

pfalstad avatar Jan 15 '25 18:01 pfalstad