picoweb icon indicating copy to clipboard operation
picoweb copied to clipboard

Remove redundant while loop on sub app search

Open laky55555 opened this issue 5 years ago • 1 comments

It looks like while loop around sub app search became redundant. As far as I can see it won't change code if it is removed.

laky55555 avatar Jul 22 '19 20:07 laky55555

So, I have to admit that patches like this point to the lack of testsuite in the project. Because well, it took me some 5 mins to remember that the idea was to support black-box functioning of mounted sub-apps, i.e. a user shouldn't be concerned if a webapp it mounts is itself consists of subapps, and thus subapp resolution should be done recursively. This is what the outer while loop handles.

pfalcon avatar Jul 22 '19 21:07 pfalcon