Paul Sokolovsky

Results 646 comments of Paul Sokolovsky

This seems to have been already suggested in https://github.com/pfalcon/picoweb/pull/23 . My question remains the same: Does this solve a real issue? If so, I'd like that issue to be described...

There're basically 2 strategies: 1. Make sure these codes aren't present in the Huffman tree, and thus decoding them leads to an error. There's a problem then: a) ensure that...

286 vs 288, 30 vs 32 dichotomy is also mentioned in my old StackOverflow question, https://stackoverflow.com/questions/25431160/what-is-the-maximum-size-of-encoded-dynamic-huffman-tree-as-used-by-deflate-zli/25462620, which has useful further references on the matter.

(This comment was originally posted on the wrong ticket, on 2018-07-09.) In https://github.com/pfalcon/uzlib/pull/10#issuecomment-403219312, I decide to go for p.2 for now, simply because it's more obvious how to patch in...

https://github.com/pfalcon/uzlib/pull/10/commits/4c50ea3f9ea046dbe2d1cdc789bb52e4e5b2cb04 proposes to de-inline TINF_PUT. While definitely beneficial for code size, performance impact should be assessed.

The short reply that uzlib follows dependency injection pattern re: memory allocation. The longer reply is that while what the short reply says is true, but some parts are taken...

Thanks for the report! Please see https://www.chiark.greenend.org.uk/~sgtatham/bugs.html, in particular that part where you need to provide specific steps/code/data to reproduce the issue.

Sorry for the delay here, busy with other projects. > I'm working on an embedded project so I can't really give you the code used to reproduce the issue as...

Good to know that someone (like me) hit something similar before ;-). I however agree that something like "you need to provide longer buffer than needed to finish decompression in...

Thanks, but I don't think the description of your patch is correct. "Streamed io" is what I implemented in v2.0. It works either for single byte reads from compressed stream,...