pf4j icon indicating copy to clipboard operation
pf4j copied to clipboard

Do we need demo_gradle module?

Open decebals opened this issue 8 years ago • 6 comments

I prefer to eliminate demo_gradle module, to "merge" this module (build scripts and the kotlin part) with demo module. The code in demo_gradle is redundant in my opinion.

decebals avatar Sep 20 '17 19:09 decebals

I don't use Gradle in my project and from this reason it's hard for me to maintain it (I admit that I don't know to much about Gradle).

decebals avatar Sep 20 '17 19:09 decebals

@decebals I started using PF4J a couple of months ago and I am using Gradle, the demo was a big help for me. I opened https://github.com/decebals/pf4j/pull/177 to fix the demo and update PF4J to the latest version. Please have a look. (We can place it inside the demo folder)

acesar avatar Oct 21 '17 18:10 acesar

@acesar Thanks for your contribution! I don't realize yet if it's better to move the gradle scripts in demo directory and to remove demo_gradle.

decebals avatar Oct 21 '17 20:10 decebals

I don't realize yet if it's better to move the gradle scripts in demo directory and to remove demo_gradle.

I'd definitely vote for having demo/maven and demo/gradle.

sschuberth avatar Apr 24 '23 07:04 sschuberth