pex-renderer icon indicating copy to clipboard operation
pex-renderer copied to clipboard
verified publisher icon pex-gl

Verify BRDF implementations in PBR.frag

Open vorg opened this issue 8 years ago • 10 comments

There seem to be three in place...

vorg avatar May 19 '17 18:05 vorg

There is quite difference between pex and BabylonJS or ThreeJS https://github.com/vorg/pbr-compare screenshot

vorg avatar May 09 '18 13:05 vorg

Existing implementations

Cesium https://github.com/AnalyticalGraphicsInc/cesium/blob/d64ae0ac77a9ec3fb4fa27d2dfc9a7c7a86310f3/Source/ThirdParty/GltfPipeline/processPbrMetallicRoughness.js

glTF WebGL http://github.khronos.org/glTF-WebGL-PBR/

glTF https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#appendix-b-brdf-implementation

vorg avatar May 09 '18 13:05 vorg

Filament https://github.com/google/filament

vorg avatar Aug 11 '18 21:08 vorg

Reopening since we moved to Filament implementation

vorg avatar Jul 15 '19 13:07 vorg

Status update: I've printed all the code on 5 pages of A3 and will do manual review at home

vorg avatar Jul 17 '19 13:07 vorg

  • [ ] update pbr-compare to the newest pex-renderer
  • [ ] rotate cubemaps in all engines if possible to the same orientation
  • [ ] write down differences and possible causes

vorg avatar Sep 09 '19 08:09 vorg