pex-renderer icon indicating copy to clipboard operation
pex-renderer copied to clipboard

Shader compilation errors are swallowed

Open vorg opened this issue 6 years ago • 3 comments

I believe it was introduced so the pex-nodes gui doesn't crash on shader recompilation.. We return "renderer red color" shader when compilation fails: https://github.com/pex-gl/pex-renderer/blob/master/index.js#L361

vorg avatar Jan 02 '19 08:01 vorg

Options:

  • Signal renderer.error.on((e) => { }) so it's consistent with component.changed
  • EventListener renderer.addEventListener('error', (e) => { })
  • capture and re-throw

vorg avatar Jan 02 '19 08:01 vorg

For now i'm re-throwing errors in cx branch https://github.com/pex-gl/pex-renderer/commit/fb82203f51a95481997b22b2d0d938ec62861d85

vorg avatar Jan 02 '19 09:01 vorg

This is being worked on here https://github.com/pex-gl/pex-renderer/pull/120

vorg avatar Jan 02 '19 09:01 vorg