pex-renderer icon indicating copy to clipboard operation
pex-renderer copied to clipboard

Z-fighting artifacts when postprocessing is on

Open vorg opened this issue 7 years ago • 1 comments

Caused by the regression introduces in https://github.com/pex-gl/pex-renderer/commit/8d0eda91e49541f2e195a4309c48572b61cd6ec1#diff-168726dbe96b3ce427e7fedce31bb0bcL544 - we no longer copy projection matrix so the depth scaling by 0.99 doesn't work and the artefacts reappear.

    if (shadowMapping) {
      camera.set({ far: far * 0.99 })
    }
    sharedUniforms.uProjectionMatrix = camera.projectionMatrix
    if (shadowMapping) {
      camera.set({ far: far })
    }
screenshot 2018-11-03 at 23 35 40 screenshot 2018-11-03 at 23 28 45

vorg avatar Nov 04 '18 00:11 vorg

Reopening as it happens again in 3.0.0-37 http://localhost:8080/?name=gltf as described here https://github.com/pex-gl/pex-renderer/issues/241

vorg avatar Sep 10 '19 15:09 vorg