Lacey Pevey comments

Results 25 comments of


                                            Lacey Pevey

@Override decorator for overriding methods in core services

An additional thought: If we were to create a new decorator, `@Override`, and use this for any service classes intended to override core services of the same name, perhaps we...

@Override decorator for overriding methods in core services

I like the idea of the decorator if I can figure it out, since Vendure/NestJS already makes heavy use of decorators. I think it would make the DX feel more...

@Override decorator for overriding methods in core services

It looks like whether going the config route or the decorator route, the basic functionality will need to happen within the `ServiceCoreModule` in service/service.module.ts. The flow seems to be: -...

@Override decorator for overriding methods in core services

I think to make the ServiceCoreModule take in the overrides stashed in config, the ServiceCoreModule will need to be made a Dynamic Module, very similar to the PluginModule. The ServiceModule...

@Override decorator for overriding methods in core services

Per Discord discussion, I'm closing this issue for now. We may want to revisit this at a later date, but overriding core service methods could create unpredictability as Vendure plugin...