petterreinholdtsen

Results 271 comments of petterreinholdtsen

I have not had time to test it. Bdale, what about you?

There are two automated checks failing for this pull request. Perhaps it need an update?

Not quite sure what kind of messages you want, but taking the message you already posted, I see this difference in the JSON output for the two drivers multical403 and...

Is there any hope to have the security issues in libelfin solved? https://security-tracker.debian.org/tracker/source-package/libelfin list seven unsolved CVEs at the moment.

Any hope to have this fix merged?

Note, tagged releases would help the Debian packaging of this software a lot. https://tracker.debian.org/pkg/yagv

Debian worked around this issue by disabling the test using the patch available from https://salsa.debian.org/science-team/freecad/-/blob/master/debian/patches/2030-fix-1017598.patch , see also https://bugs.debian.org/1017598 .

I had a look at the code, and found the location where 'diff' is used to compare the real output with the expected output. ``` index 6e457e92a1..984d2efc55 100644 --- a/src/Mod/Fem/femtest/app/support_utils.py...

Would something like this b acceptable, reducing the number of digits after comma in the printout? ``` --- freecad-salsa.orig/src/Mod/Fem/App/FemMesh.cpp 2023-07-09 08:35:17.346123383 +0200 +++ freecad-salsa/src/Mod/Fem/App/FemMesh.cpp 2023-07-09 08:35:17.342123374 +0200 @@ -2137,6 +2137,13...

[Vladimir] > artificially truncating the output makes the results non-portable in > that sense you won't be able to use them anywhere else outside the > program. I do not...