youpez-admin icon indicating copy to clipboard operation
youpez-admin copied to clipboard

plan to port to angular 17 ?

Open zucatti opened this issue 2 years ago • 17 comments

zucatti avatar Dec 19 '23 17:12 zucatti

Hi @zucatti . Do you want to port it to angular 17? I may contribute. I am not advanced in Angular but willing to use it too. So if the owner agrees, maybe we can do it?

ENate avatar Jan 18 '24 08:01 ENate

This is definitely a good idea, I wonder if the owner are interested?

cgglyle avatar Feb 13 '24 16:02 cgglyle

Hi @cgglyle any ideas on how to get hold of the owner or we can go it ourselves?

ENate avatar Feb 13 '24 17:02 ENate

Hi @ENate

The owner doesn't look like he's updated any code in two years, it looks like the whole project is no longer being maintained, and I'm just a front-end beginner who was hoping to learn angular through the whole project, but it's a headache with version dependency issues and obsolescence.

cgglyle avatar Feb 13 '24 23:02 cgglyle

@ENate And the commit log for this project has no valid information. E.g. update, wip, sadasdsa, fsfd... It looks like the owner is not interested in writing detailed logs.

cgglyle avatar Feb 13 '24 23:02 cgglyle

Hi Guys,

You can freely port this project to angular 17 if you want.... and you can open a PR for it, and I will review it and I can make you a contributor of this project.

"It looks like the owner is not interested in writing detailed logs." What kind of detailed information do you need here? The "sadasdsa" commit was just "Initial commit"

petter-ka avatar Feb 14 '24 08:02 petter-ka

Hi @petter-ka thanks for the template and getting back. So are we all ready to port this to angular 17?

ENate avatar Feb 14 '24 10:02 ENate

Hi @petter-ka I actually took a look at the project and also trying to update it. It seems there are quite some changes especially with the Carbon Design system. My question is: Can you comment on the tailwind.css file in the assets folder? I do not know whether you customized the project using the entries in that file? I plan to open a PR for Angular 17 if I finalize the updates! Anyone is welcome to join. Thanks

MHipo avatar May 01 '24 13:05 MHipo

Hi @MHipo ,

The tailwind.css is the original tailwind style file, because back then I did not make it to work with the standard way. So I just copy pasted it. Besides, you are right, the Carbon System is changed a lot. You can free to open a PR, and I will check it if you want

Thank you P

petter-ka avatar May 14 '24 10:05 petter-ka

hI @petter-ka I have a good update of most of the packages but stuck somewhere with issues relating to styles. Can you check and make comments? I can open a PR with what I have done so far.

ENate avatar Aug 16 '24 15:08 ENate

Hey @ENate , I was about to start upgrading this Project to Angular latest. Can you please create a PR, I can have a look into it. This would be really helpful.

Thank you!

Nileshmnk27 avatar Aug 16 '24 18:08 Nileshmnk27

Yes @petter-ka. Done!

ENate avatar Aug 17 '24 21:08 ENate

Hi @ENate , It looks good so far, but please try to make it to work with vercel deployment. So I can see the builded version

petter-ka avatar Aug 18 '24 08:08 petter-ka

Hi @petter-ka . Will do. But know that parts of the update with styling is not working. I do not know whether this will affect the vercel deployment. But if it is just the for the build, then I guess then fine.

ENate avatar Aug 22 '24 12:08 ENate

Hi @ENate , We need to get work with vercel preview (the fully deployed demo). Can you comment the involved code parts in the PR that is not working?

petter-ka avatar Sep 07 '24 06:09 petter-ka

Hi @petter-ka . Sure I can. But I have never used vercel until now :). If I register and deploy to vercel, will it be faster for you to check? And if it deploys to vercel, can you see the issues from there? The main issue I encountered was with the themes section (folder). I was unable to fully update the whole themes. I noticed that there were a number of changes to the latest Carbon theme versions. In my opinion, it seems the issues were mainly how they were imported to the app. I also tried to link in tailwindCSS as discussed in the doc and there were still some issues - but I finally noticed that the issue may be due to the IDE I used. I presume we may not need to directly copy the tailwind.css file but create a config file and link up the CDN.

I do not know if these issues will show up if I deployed first on Vercel. What do you think? I can provide further details about the issues. Great job you did with the original template. We can finish the remaining updates if these issues are clarified in my opinion.

ENate avatar Sep 07 '24 12:09 ENate

Hi @petter-ka It may be best to update to standalone though. If you confirm this, I may consider too.

ENate avatar Oct 02 '24 06:10 ENate