Lucian Petrut

Results 41 comments of Lucian Petrut

@idryomov Thanks for reviewing this patch, please let me know if there's anything else that needs to be updated.

I've prepared some Windows tests as well: https://github.com/petrutlucian94/ceph/commit/62d9178dec82666b8b5d05fed5023a2784403df0 That commit is based on another PR, which breaks the Windows Python tests into separate modules and makes the code reusable: https://github.com/ceph/ceph/pull/52560....

@idryomov I've addressed the comments and squashed the commits, I think it's ready to merge. Thanks again for the review.

@idryomov since https://github.com/ceph/ceph/pull/52560 merged, I've added some Windows import/export tests.

> Looks good. > > Perhaps you missed replacing in a few following places - https://github.com/petrutlucian94/ceph/blob/tests/src/libcephfs.cc#L666 https://github.com/petrutlucian94/ceph/blob/tests/src/test/libcephfs/test.cc#L1361 https://github.com/petrutlucian94/ceph/blob/tests/src/test/libcephfs/test.cc#L271 Indeed, thanks for pointing those out. I think I searched for "-E"...