petros comments

Results 46 comments of


                                            petros

Add support for artifactory and private repositories

> @petroseskinder Any updates on this? @wstrange thank you. Due to start of the semester, I have temporarily limited my role on the project. That said, I can help polish...

BFG should set a default visibility in all generated BUILD files

@cgrushko Style guide states that the default should not be "public" What are you thinking for the default visibility?

How to add a new maven deps and upgrade old maven deps to WORKSPACE file

There will be after #46 is merged. Its a repository rule called `transitive_maven_jar`.

Bazel incompatible flags

thanks for updating @greggdonovan

Homebrew formula for generate_workspace

This sounds like a great idea. Would this involve simply creating a homebrew tap?

Homebrew formula for generate_workspace

Thanks for the link. I shouldn't have a problem writing up the formula. I'll ping you for a review.

#39 Remove usage of deprecated build-in http_archive rule.

@buchgr @philwo @fweikert could I also get access to BuildKite? I blanket approved so that once @greggdonovan figures out the errors he wouldn't be blocked needing a review.

Fails with google-cloud-storage (version missing)

Thanks for the post. `transitive_maven_jar` is simply a wrapper around `generate_workspace` so it will fail in the same fashion as `generate_workspace`. The original maintainer has left the project, and I...

When generating BUILD files, Put abstract test classes into java_library, not java_test

What abstract test classes are you referring to? There are no abstract classes in `src/test/java/com/google/devtools/build/bfg`

When generating BUILD files, Put abstract test classes into java_library, not java_test

Ohh. Can you clarify that within the description of the issue? Because my previous interpretation was that you were referring to source files and rules within the BUILD_file_generator project.