Petros Angelatos
Petros Angelatos
> I expect users to ask us for a solution that allows them to not discard all state of the v0 source table in v1. For example, if they have...
Linking also some previous agreement on offering both flavors of this API https://github.com/tokio-rs/bytes/pull/445
> How do you think about the fact that compute currently has its own custom implementation of the persist sink? Is that just a weird happenstance and that code is...
Why is zero group size not well defined? It's a valid size for a group
I was unable to trigger a miri failure with this. I seems to have something to do with how deeply value validity is checked because miri correctly flags this code:...
@RalfJung if you have any pointers for how to write a miri test for this PR I'm happy to have another go at it.
oh, amazing! I will add a testcase
I see. This particular test exercises very little code but I don't have a strong opinion either. If we want to avoid using this experimental feature until the validity UB...
@tgross35 great! Just added a miri testcase for this. I did pass the experimental flag, meaning that the test fails without the fix.
In light of the discussion from the unsafe code guidelines repo it's clear that this PR is in a gray area as to whether it fixes UB or not. The...