forge-sdk-python icon indicating copy to clipboard operation
forge-sdk-python copied to clipboard

Wrong type annotation

Open paoloq opened this issue 3 years ago • 2 comments

Hi, I encountered an error caused by a wrong type annotation.

def get_authorization_url(
        client_id: str, response_type: str, redirect_uri: str,
        scopes: list[Scope], state: str = None
    ) -> str

As you can see in the case above, list[Scope] causes a runtime error because list is not the right way to type annotate. It should be changed in List, imported from typing.

I'm going to PR a fix in few minutes, I created this issue just for completeness.

Btw, thanks for starting this great work in creating an SDK for Forge API. I'm likely to start contributing in next weeks as I'll need it for a new project.

paoloq avatar Nov 11 '21 11:11 paoloq

Hi @paoloq I think this is related to #9. If you use python 3.9 or later you should not get the error.

Magnus-COWI avatar Nov 01 '22 13:11 Magnus-COWI

I've updated the typings in the latest commit (https://github.com/petrbroz/forge-sdk-python/commit/432b3ce3a83f97425783127e9b6776f830ccd055). To be honest, I'm not very experienced with typings in Python, so I'm not sure whether to use typings.List or list?

petrbroz avatar Nov 08 '22 15:11 petrbroz