jeffrey icon indicating copy to clipboard operation
jeffrey copied to clipboard

add support for compressed jfr

Open lucasamoroso opened this issue 1 year ago • 1 comments

Description

This PR adds support for handling compressed JFR files in Jeffrey. The changes ensure that both compressed and uncompressed JFR files can be uploaded and analyzed seamlessly.

Changes

FileBasedRecordingManager.java: Updated the upload method to detect and handle gzipped JFR files. RecordingController.java: No changes needed as the upload method in FileBasedRecordingManager now supports compressed files.

Testing

Tested with tag 0.2:

Compressed Files: Upload and analysis work correctly. Uncompressed Files: Upload and analysis work correctly.

Tested with master branch:

Compressed Files: Upload works correctly, but there are issues with profile analysis. Uncompressed Files: Upload works correctly, but there are issues with profile analysis.

Notes

The current implementation ensures backward compatibility with uncompressed files. Further investigation is needed to resolve profile analysis issues in the master branch.

Please review the changes and let me know if any adjustments are required.

lucasamoroso avatar Sep 07 '24 20:09 lucasamoroso

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 07 '24 20:09 CLAassistant

Thanks for your contribution, but the it's no longer valid. I will try to iterate on your idea to have compressed JFR recordings but it has very low priority at this moment

petrbouda avatar Jul 14 '25 07:07 petrbouda