Anna Petrasova
Anna Petrasova
@andrewg-cse thank you for this important contribution!
> @petrasovaa @wenzeslaus > > Is this patch included in current developmental versions of GRASS 8.3.0 available here - https://wingrass.fsv.cvut.cz/grass83/ ? Yes!
The change from this PR would likely not influence your results, the slopes would have to be much higher. But I am getting different results:  ``` r.sun.daily elevation=hot aspect=aspect...
> I get the same results as you do if I just run r.sun.daily. But this seems to change if r.horizon is used. > > Can you please try the...
This is for 7 billion cells.  It does not scale great, but it's still a nice improvement, it can decrease time roughly by half. I believe this is ready...
Would it be enough to remove the thumbnail call from v.colors Makefile? I don't think there is any reason why v.colors should be compiling it again.
I don't see anything particularly wrong about this code, adding sleep might help, but I don't think it's solving the source of the problem, which I believe is in the...
> I applaud this initiative. Could/should be done on most other modules. > > Briefly find a few minor issues, commented in line. Thank you, I applaud you reviewing this!
> > These are the results of r3.univar -g map=test_flowaccum, which indicates that the problem perhaps either lies with r3.univar and/or the expected test results. > > Alternatively, if indeed...