terraform-provider-mysql icon indicating copy to clipboard operation
terraform-provider-mysql copied to clipboard

Published 20 hours ago • verified publisher icon petoju

Run tests on MySQL 8.4

Open shmokmt opened this issue 8 months ago • 1 comments

shmokmt avatar Apr 07 '25 04:04 shmokmt

Could you please skip/fix tests failing on 8.4?

I understand we could run tests there and it would be helpful. However, I don't see any benefits of just adding test runs without fixes.

petoju avatar Apr 07 '25 06:04 petoju

What about changing it to 8.4.5 if https://github.com/petoju/terraform-provider-mysql/pull/225 is approved?

maximmasiutin avatar Apr 23 '25 12:04 maximmasiutin

@maximmasiutin If poteju agrees with this, I think it's fine. Thanks!

shmokmt avatar Apr 23 '25 14:04 shmokmt

The tests are not passing - could you please rebase it to the latest master?

I actually don't care that much, whether it's 8.4 or 8.4.5 - I prefer the latter one as that's tested when one runs it locally.

petoju avatar Apr 23 '25 20:04 petoju

I rebased it and now all the tests pass.

shmokmt avatar Apr 24 '25 00:04 shmokmt

Thanks! Merging

petoju avatar Apr 24 '25 20:04 petoju