Petka Antonov

Results 42 comments of Petka Antonov

Maybe it could be rewritten to be a bit less cringe inducing

need to investigate if its possible to support, some cancellation code might be dependent on identity

Seems like a bug, doesn't look like those lines should be removed by cleanStack

Yeah this needs to be rewritten as loop https://github.com/petkaantonov/bluebird/blob/master/src/cancel.js#L9-L39

Something like this would be most straightforward :D: ```js Promise.prototype["break"] = Promise.prototype.cancel = function() { if (!debug.cancellation()) return this._warn("cancellation is disabled"); var stack = []; var promise = this; var...

Yep there's [Promise.AggregateError](http://bluebirdjs.com/docs/api/aggregateerror.html) that implements array and error interfaces

Warnings can be disabled with environment variables or .config ```js //module 2 function doSomething2() { return fakeWork() .then(() => { doSomething1(); //calling another module, but not aware that it uses...

Forced serialization is to avoid memory leak isn't it?

I see, could probably create a flag for lazy serialization? PR welcome