gps-messenger-bundle
gps-messenger-bundle copied to clipboard
petitpress
BC break in 1.4 because of extension class renaming
#18 broke BC by renaming the extension GpsMessengerExtension to PetitPressGpsMessengerExtension.
This should be either documented as such, or better, reverted, maybe reintroduced in 2.x after proper deprecation.
That class is marked as final and should not be used outside of this bundle. Can you please give us more information about the issue? Why do you think it is BC break? Do you see some errors?
The change was needed as the PR adds new configuration option and I wanted to make this bundle more compatible with Symfony bundle best practices without renaming the main bundle class.
Hello @pulzarraider, thanks for your input.
Marking a class final prevents to extend it, not to refer to it outside of the scope of the package.
If you don't want people using that class at all (or at least not in the scope of your BC promise), then it should be marked @internal instead.
However, in my opinion, it should not, also it is designed to be used by external Symfony code.
My use case is that in project we use the PubSub transport across many Symfony based apps, so we made a small package/bundle to ease our configuration of this bundle in all of them. Hence we have some integration tests requiring to add this extension in the container builder.
I would be happy to send a PR at the end of the week to discuss a way to fix BC without reverting anything, if you would consider it. Thanks!
@HeahDude Thank you for your MR. This bundle has already version 2 available. I think we can close this issue.