Peter Zhu
Peter Zhu
Sorry, I've been very busy recently with various things at work and this PR is very large, so I haven't been able to spend enough time on this. I will...
I think this looks good, but I would like one of the maintainers to give input before merging.
It looks like this is failing on Solaris and OpenBSD: ``` 1) Failure: TestSocket_UNIXSocket#test_seqpacket_pair [/export/home/chkbuild/chkbuild-gcc/tmp/build/20230830T210012Z/ruby/test/socket/test_unix.rb:493]: expected but was . ``` http://rubyci.s3.amazonaws.com/solaris11-gcc/ruby-master/log/20230830T210012Z.fail.html.gz http://rubyci.s3.amazonaws.com/solaris10-gcc/ruby-master/log/20230830T220004Z.fail.html.gz http://rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20230830T223006Z.fail.html.gz
We're running into the same issue as #3981. Here's the relevant backtrace: ``` #4 0x000055eecec7824d in sigsegv (sig=11, info=0x7f76f5e5c930, ctx=0x7f76f5e5c800) at signal.c:964 #5 #6 0x00007f770525faab in __pthread_clockjoin_ex (threadid=threadid@entry=140143353931520, thread_return=thread_return@entry=0x7f75e4ad37e0, clockid=clockid@entry=0,...
We're running 0.13.0 of rdkafka-ruby.
@mensfeld I opened appsignal/rdkafka-ruby#278. I debugged this further and I think appsignal/rdkafka-ruby#277 might fix the issue.
> Was the behaviour consistent between liquid and liquid-c? Yes, see eab12e1240ece8b6722f74b7d81af0b96242c2f3 (this commit is before the Gemfile was updated to point to the branch on `liquid-c`).