Peter Willemsen

Results 86 comments of Peter Willemsen

I made a separate api account and marked it as 'bot', which is also a bit more secure since if the lcs software ever gets hacked, you can just ban...

Hi @Fmstrat sorry for the ping, this might be interesting to you, it'll bring arm support to your Docker image without any changes to the source code. I tested it...

Fixed a bug with a negative PNL and also added an epsilon to compare the actual stoploss v.s the trailing stop accurately! Now a trailing stop with 2% (Ignoring take...

![image](https://github.com/hummingbot/hummingbot/assets/1212814/0f479447-a549-47dd-83af-5620640973b6) Stoploss now stays at a max of it's previous value, reflecting irl scenarios. I use vectorized operations and avoid loops for this so performance isn't affected. The code is...

Hey lovely @cardosofede , yeah I can, but I never used DCA simulator before. I cannot assert it's correctness as well as with PositionExecutor, because I can actually see what...

Hey lovely @cardosofede ! Sorry for late reply I understand what you're saying. But in live trading isn't it so that the stop loss rises if the price moves in...

@cardosofede thanks for the explanation, I updated the PR and it now contains your feedback + I updated to the latest development branch! I tested out the code and got...

@cardosofede Thanks for the feedback, you were right, there was an issue that if pnl drops again, the trailing stop fails to trigger. I took your second advice to fix...

> Great job @peterwilli Awh thaaaaanks!! It was lovely to work with you hehe

@cardosofede c-could you see if this can be reviewed still? It's been almost a month, I think it could be useful