Peter Donovan

Results 78 comments of Peter Donovan

The following data were generated using a script that I added in the `a-b-test` branch. This script is a work-in-progress, and I am not sure if it is something that...

> Let me know if your use-case is not supported yet by the script, then we should extend it. I agree it would be ideal to use the benchmark runner....

> Perhaps one option to try is to not use a resizing array, but rather fixed-size array, and when that fixed size is exceeded, fall back on old method. I...

The most recent version of this branch is a bit better now, and I think that the test failure might just be happening due to memory issues compiling SleepingBarber (but...

> Do you think it would be possible to combine this with target language formaters and run, let's say, clang-format on the code bodies? Yes, I believe we plan to...

I just realized that this approach to formatting can make code like this unreadable: ``` test = new TraceTesting( events_size = 5, trace_size = 165, trace = ( 0,0,0,1,1,0,0,0,0,0,0, 500000000,0,0,0,1,1,1,0,0,0,0,...

> I don't quite understand the code example. Is this LF code or target code? It is LF code, copied directly from a [modal models test](https://github.com/lf-lang/lingua-franca/blob/master/test/C/src/modal_models/ModalStateResetAuto.lf). Yes, I also like...

> would the `// keep-format` only apply to the annotated AST node? Yes. As it turns out, having a single comment that applies to the annotated AST node is much...

Can we try to merge this soon? I promise that the change I just made was trivial and that this has mostly just been awaiting review for 23 days.

Let's close it. This PR might be, or might once have been, a net win, but the objectives that it was aiming for are no longer important to me and...