Peter van der Walt

Results 133 comments of Peter van der Walt

Still waiting on feedback from @electron-userland team on this, seems the documentation has not been updated to reflect the newer requirements that all CAs are forcing

Thanks for checking in Have a read through https://knowledge.digicert.com/generalinformation/new-private-key-storage-requirement-for-standard-code-signing-certificates-november-2022.html - theres a new standard around where one can no longer store your key locally, has to be on a token,...

Please test that this did not break arcs for other gcode :)

Also unable to compile for ESP32-S3. Works great on old plain ESP32

@samuelmeuli please please fix this (: We can't live without your Action! ``` Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use...

> > @samuelmeuli Yes, my project literally depends on this for releases. Please update it. > > Just update the node version in the yml file from 10 to 16...

> @petervanderwalt No, in the yml file that you put in your `.github/workflows` directory, https://github.com/marketplace/actions/electron-builder-action I have, see https://github.com/OpenBuilds/OpenBuilds-CONTROL/blob/55749cf07e6e4ebbacb59d5b5b25a493950660b0/.github/workflows/build.yml#L21 - but thats exactly when GA complains that the Action (which...

> why the action itself needs to be updated. Exactly - So my earlier comment. > Is it https://github.com/samuelmeuli/action-electron-builder/blob/master/action.yml#L56 that should be changed? After all then.

> Yep! I forked the repo and changed it myself and everything worked fine. Figured, thanks!

Thanks for the update, we forked at the time and figured it out. Also adapted the action to do the stuff we wanted, so we are good for now, but...