gitflow-avh icon indicating copy to clipboard operation
gitflow-avh copied to clipboard

Restores previous default branch prefixes, closes #393

Open adamrodger opened this issue 7 years ago • 4 comments
trafficstars

Fixes https://github.com/petervanderdoes/gitflow-avh/issues/393

The prefixes are now the values that were used previously, e.g.:

$ git flow init -d
Initialized empty Git repository in /tmp/test/.git/
Using default branch names.
No branches exist yet. Base branches must be created now.
Branch name for production releases: [master]
Branch name for "next release" development: [develop]

How to name your supporting branch prefixes?
Feature branches? [feature/]
Bugfix branches? [bugfix/]
Release branches? [release/]
Hotfix branches? [hotfix/]
Support branches? [support/]
Version tag prefix? []
Hooks and filters directory? [/tmp/test/.git/hooks]

adamrodger avatar Nov 06 '18 20:11 adamrodger

Can we get this merged and a new release ASAP please, the latest release has broken our builds due to this changed behaviour.

27Bslash6 avatar Jan 25 '19 01:01 27Bslash6

I don't know what plans were for next release, but please please prioritize a release with this in it!

AndydeCleyre avatar Feb 12 '19 18:02 AndydeCleyre

@petervanderdoes it appears you've reimplemented my changes from this PR and not given me any credit for it which seems a bit unfair to the community. I did the hard work to actually find and fix this issue.

For what it's worth, I also reviewed the merged changes and I still think my implementation is clearer and neater.

adamrodger avatar Feb 28 '19 14:02 adamrodger

My apologies @adamrodger I saw an email when I got to work and quickly made some changes without checking if there were PR's or not.

I will add your name to the changelog.

I just checked your code and wanted to comment on my implementation compared to yours.

My thought process is that if you use a parameter you explicitly tell the software that the given name is the name you want. In your implementation it still checks if there is a setting in a configuration somewhere and that would take precedent over the parameter.

petervanderdoes avatar Feb 28 '19 16:02 petervanderdoes