Peter Sopko

Results 154 comments of Peter Sopko

> i believe you have to set this CYPRESS_RECORD_KEY in the repository as well since we don't push our `.env` file to remote. maybe this [article](https://glebbahmutov.com/blog/secrets-to-env/) can help it is...

> * use https://circleci.com/, "If you are comfortable sharing secrets with anyone who forks your project and opens a PR, you can enable the Pass secrets to builds from forked...

expanding e2e test suite makes no sense without parallelization, this needs to get revisited once somebody manages to do that

@spacesmutje just a limit set for first time contributors :) should be good now

tbh not sure what's the problem here now, seems that netlify can't build this one?

> @petersopko yes, something is going wrong with lint. no idea what it is though. there were some invalid jsons files (missing commas and stuff), seems to be working now...

@yangwao can you please check the deploy here / what can be done 😄 I don't see why isn't it redeploying again

@spacesmutje the app is now deployed, please click through it and make sure there aren't any leftovers, here's some examples I found: ![image](https://user-images.githubusercontent.com/73316633/189912842-297a2393-4824-41e6-ab46-707d1a1e8932.png) ![image](https://user-images.githubusercontent.com/73316633/189912875-1b6c6ebe-dc2e-4782-9411-0b61538f4976.png) ![image](https://user-images.githubusercontent.com/73316633/189912941-30fc336c-38dc-4230-bb9d-c60d18b98256.png) ![image](https://user-images.githubusercontent.com/73316633/189913072-e0520484-a1ff-46aa-ad4f-4d966af735fc.png) I'm wondering whether these...

> Seems this one issues did not covered landing it was just faulty json, it's there now: ![image](https://user-images.githubusercontent.com/73316633/189914172-d486b58a-523c-4f18-b035-b43c08e14ba2.png)

> you can inspect deploy logs yourself I know, it was just failed deploy and the new one wasn't showing up until recently :) ![image](https://user-images.githubusercontent.com/73316633/189914566-f2f7c490-7be1-4d43-b0d5-95986e7bf987.png)