Peter Rehm

Results 11 comments of Peter Rehm

Actually I had a ssl error, the upgrade to the latest PHP 7.1. version (liip php osx) fixed it for me.

I am not using others, the question is if there are other. As we cannot know what others want to do prior the forst visit call I would suggest then...

Shall I submit a PR for the autostart and the session handling? So just silently do not restart it if already started?

@yakobe See in the PR's, both are awaiting to be merged. You can meanwhile fix that in your CI suite by manually starting the session. Or what issues do you...

````php /** * @BeforeScenario */ public function beforeScenario() { if ($this->getSession()->getDriver() instanceof Selenium2Driver) { $this->getMink()->getSession()->start(); $this->getSession()->resizeWindow(1440, 900, 'current'); } } ````

Btw how about this and the related PRs? Shall I close them?

I know, but as there is no activity in regards to the PRs. I can close them if not wanted.

- https://github.com/minkphp/MinkSelenium2Driver/pull/265 - https://github.com/minkphp/Mink/pull/732 - https://github.com/minkphp/Mink/pull/733 - https://github.com/minkphp/driver-testsuite/pull/10

If I recall correctly this introduced the issue: https://github.com/minkphp/Mink/commit/acf5fb1ec70b7de4902daf75301356702a26e6da And the issue is the session gets restarted without the checks.