lost icon indicating copy to clipboard operation
lost copied to clipboard

Adds global setting for `gridUnit`

Open peterramsing opened this issue 3 years ago • 1 comments

What kind of change is this? (Bug Fix, Feature...) Enhancement

What is the current behavior (You can also link to an issue) @lost gridUnit vw didn't do anything

What is the new behavior this introduces (if any) It does!

Does this introduce any breaking changes? Nope

Does the PR fulfill these requirements?

  • [x] Tests for the changes have been added
  • [ ] Docs have been added or updated

Other Comments

peterramsing avatar May 30 '22 19:05 peterramsing

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (825b364) 100.00% compared to head (5366ffd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #452   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          776       778    +2     
=========================================
+ Hits           776       778    +2     
Impacted Files Coverage Δ
lib/lost-at-rule.js 100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 30 '22 19:05 codecov[bot]

...after playing with this more, I realized this breaks things if you use vw where you'd instead want vh. Globally setting this only works for one direction. 🤔

peterramsing avatar May 06 '23 21:05 peterramsing