ImageProjectiveGeometry.jl icon indicating copy to clipboard operation
ImageProjectiveGeometry.jl copied to clipboard

CompatHelper: bump compat for Images to 0.25, (keep existing compat)

Open github-actions[bot] opened this issue 3 years ago • 4 comments

This pull request changes the compat entry for the Images package from 0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22, 0.23, 0.24 to 0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22, 0.23, 0.24, 0.25. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

github-actions[bot] avatar Nov 26 '21 00:11 github-actions[bot]

Codecov Report

Merging #27 (230966e) into master (6b64aaa) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   44.33%   44.33%           
=======================================
  Files           8        8           
  Lines        1985     1985           
=======================================
  Hits          880      880           
  Misses       1105     1105           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b64aaa...230966e. Read the comment docs.

codecov-commenter avatar Nov 26 '21 00:11 codecov-commenter

I haven't yet looked into the codes, but it's perhaps also doable to remove the Images dependency.

johnnychen94 avatar Nov 26 '21 01:11 johnnychen94

I noticed an ancient usage Images.Image in https://github.com/peterkovesi/ImageProjectiveGeometry.jl/blob/6b64aaae7da89267ff75e2b562a4db81ed367882/src/cornerfeatures.jl#L116; this no longer exists.

The test coverage is only 44%, my best guess is that a large portion of functionalities in this package are broken already. So to upgrade this package I think we need some rewrite of the basic functions first. Simply adding Images v0.25 to the Project.toml won't make anything better.

johnnychen94 avatar Nov 30 '21 07:11 johnnychen94

I agree the test coverage is rather woeful. I need to carefully step through each function removing ancient usage and improving the testing

peterkovesi avatar Nov 30 '21 13:11 peterkovesi