azure-functions-rs icon indicating copy to clipboard operation
azure-functions-rs copied to clipboard

Published 20 hours ago • verified publisher icon peterhuene

include signalr runtime must be installed

Open demoray opened this issue 5 years ago • 6 comments

What is the goal of this pull request?

To update the docs to inform users they need to install the signalr extension.

What does this pull request change?

the signalr example readme.

What work remains to be done?

N/A

Do you consider it adequately tested?

YES

Related Issues

Notes

demoray avatar May 15 '20 04:05 demoray

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @demoray on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] avatar May 15 '20 04:05 cla-bot[bot]

Hmm, the extension should automatically be installed when running an application that makes use of SignalR bindings.

Did you run into problems running the application?

peterhuene avatar May 15 '20 18:05 peterhuene

@cla-bot check

peterhuene avatar May 15 '20 18:05 peterhuene

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar May 15 '20 18:05 cla-bot[bot]

Did you run into problems running the application?

Yes. I had to install them by hand, which lead me to making the PR

demoray avatar May 15 '20 18:05 demoray

Weird, I wonder if it's because 1.1.0 is out. I don't believe I ever explicitly installed the extension while developing the SignalR bindings.

Without the extension installed and after running cargo func run -r /tmp/foo, does /tmp/foo contain **/*SignalR*.dll?

peterhuene avatar May 15 '20 19:05 peterhuene