svg-preview icon indicating copy to clipboard operation
svg-preview copied to clipboard

All navigation items are rendered inactive.

Open gnetsys opened this issue 11 years ago • 25 comments

When this item is installed all navigation items are rendered inactive.

gnetsys avatar Feb 18 '14 12:02 gnetsys

https://www.dropbox.com/s/ri0qsbvisi8dl4b/Brackets-issue.mp4, here a link to a video on the issue.

gnetsys avatar Feb 18 '14 12:02 gnetsys

Definitely doesn't happen for me, and never reported before. I see this came from adobe/brackets#6902... @gnetsys, I think in the original report you mentioned using a custom build of brackets-shell? Does the problem occur when you use a regular Brackets installed build from download.brackets.io?

It shouldn't be possible for anything in Brackets JS code to prevent the minimize/maximize buttons from working, so I'm guessing this is some sort of native problem.

peterflynn avatar Feb 18 '14 19:02 peterflynn

I never use custom builds just the release builds. I am running Brackets Sprint 36 now, the latest release, the plugin gave same issue.

gnetsys avatar Feb 18 '14 19:02 gnetsys

So just to be clear...

  • If you have no extensions enabled, and you quit & relaunch Brackets, it works perfectly fine.
  • If you install only the SVG Preview extension, and you quit & relaunch Brackets, no part of the Brackets window (including the native chrome) responds to mouse clicks.

Is that correct?

Does this problem happen with Sprint 35? Or only with Sprint 36?

peterflynn avatar Feb 18 '14 19:02 peterflynn

Yes thats correct..

gnetsys avatar Feb 18 '14 19:02 gnetsys

What about the sprint 35 vs. 36 question?

Also, if you don't mind could you test in a Sprint 30 or earlier build as well? (That is, before the "dark shell" UI was added). You can download older builds by clicking the "All Downloads" link on the download site.

peterflynn avatar Feb 18 '14 19:02 peterflynn

It happens with all version I have tested. From 32 up

gnetsys avatar Feb 18 '14 22:02 gnetsys

Could you also test with a Sprint 30 or earlier build? It's important to know whether this is specific to the 'dark shell' window style or not.

Also, can you tell me your OS version & hardware?

Also... at what point does Brackets become unresponsive to mouse clicks? Is it immediately frozen like that as soon as it loads? Or do you have to actually view an SVG file first?

peterflynn avatar Feb 18 '14 22:02 peterflynn

OS: Windows 7 8GB DDR3 / 2TB

It becomes unresponsive immediately on launch. Will test with sprint 30 and let you know by tomorrow.

gnetsys avatar Feb 18 '14 23:02 gnetsys

@gnetsys Here's another thing you could check:

  1. Launch Brackets without SVG Preview installed/enabled
  2. Verify that clicking works properly
  3. Install SVG Preview via Extension Manager. Do not restart Brackets
  4. Does clicking still work at this point? Or does it stop responding the instant you install the extension?

Thanks for helping investigate.

peterflynn avatar Feb 19 '14 05:02 peterflynn

Also, odd question but -- could you make sure your graphics drivers are up to date? (On the off chance that this is some sort of Chromium/CEF repaint related issue). I assume you have pretty recent graphics hardware?

peterflynn avatar Feb 19 '14 05:02 peterflynn

Yep am running Radeon Sapphire with 1GB dedicated.

gnetsys avatar Feb 19 '14 09:02 gnetsys

I installed a clean version of Brackets 26 and SVG preview and it worked well after install. However I left the application idle overnight and the it froze next mornig. I again could not use any navigation icons.

gnetsys avatar Feb 21 '14 02:02 gnetsys

@gnetsys Did you open any SVG files during that time? Do you still see the freeze if you don't open or view any SVG files for the entire time Brackets is open?

peterflynn avatar Feb 21 '14 19:02 peterflynn

No, I opened no SVG files during this time...

gnetsys avatar Feb 21 '14 20:02 gnetsys

@gnetsys Can you try editing your copy of the extension to comment out the ExtensionUtils.loadStyleSheet() call at the bottom of main.js? That seems like the leading plausible explanation -- something in the CSS that is loaded immediately, even if you don't view any SVG files. Let me know if the problem still happens after commenting out that call.

peterflynn avatar Feb 22 '14 00:02 peterflynn

Hi Peter, as mentionned there : https://forums.adobe.com/message/6422625#6422625 i have the same thing with the extension. I tried your last advice with no success. As soon as the extension is in the user folder, Code becomes inactive.

fr32c avatar May 31 '14 05:05 fr32c

@fr32c Sorry for slow reply. So if you comment out the ExtensionUtils block (https://github.com/peterflynn/svg-preview/blob/master/main.js#L297-L301) in my code, and then launch Brackets without opening any SVG files, you still see the problem? And it still happens immediately when Brackets is done loading, when you still haven't touched any SVG files yet?

peterflynn avatar Jun 23 '14 18:06 peterflynn

If it really still happens then, can you try commenting out the entire module body? (Lines 30-301).

peterflynn avatar Jun 23 '14 18:06 peterflynn

Well, i didn't launch Code since :) I'm feeling good on Brackets, you know, and whenever someone asks, i send them there :)

fr32c avatar Jun 23 '14 20:06 fr32c

@fr32c So you don't see this in Brackets? Only in Edge Code? That's weird...

The original report from @gnetsys was on Brackets though, so clearly whatever's going on affects a small number of installs of both versions...

peterflynn avatar Jun 27 '14 22:06 peterflynn

@fr32c Anyway, if you ever have a few min to help out, please let me know. Would love to get some more info on what's going on here...

peterflynn avatar Jun 27 '14 22:06 peterflynn

I removed svg preview. I have upgraded and installed the latest version. 0.41 will test again and give feed back...

gnetsys avatar Jun 27 '14 23:06 gnetsys

Yep, that's strange… Originally, that was a bracket's issue, that got somehow solved.

fr32c avatar Jun 28 '14 04:06 fr32c

@gnetsys Thanks a ton for your help... very interested to hear what results you get!

peterflynn avatar Jul 01 '14 06:07 peterflynn