Peter Demin

Results 52 comments of Peter Demin

I don't have a personal preference, but I want signal handling to be idiomatic to POSIX. I found this answer: https://unix.stackexchange.com/a/99143/191944 If I read it correctly, it says that for...

1. Thanks, right, it's SIGUSR1. 2. I agree that the process should run cleanup on SIGTERM to shut down gracefully. But the exit code should be non-zero (either 1 or...

@mattupstate, why you say flask.ext is going to be deprecated? I see http://flask.pocoo.org/docs/extensiondev/#extension-import-transition says it's ok.

Have you tried using HTTPS_PROXY env var, as documented here: https://requests.readthedocs.io/en/latest/user/advanced/#proxies? This should work out of the box

I see. Sounds good. Let's remove mentions of `OPENAI_PROXY_SERVER` and rely on standard `HTTP_PROXY`.

JFYI: I acknowledge the issue but I don't have bandwidth to fix it. You're welcome to propose a solution and I'll review the PR

Thanks for the thorough reply! The lack of notifications can be solved by creating a separate GitHub account, I think it can be shared multiple repos, if each repo creates...

That's a great suggestion! I'd love to incorporate that in the GitHub action. It shouldn't be a part of pip-compile-multi Python package, though.

Hi @zetsumeishi, I'll be happy to review a PR. At high-level, you'll need to add a new module in `features` and wire it up in [FeaturesController](https://github.com/peterdemin/pip-compile-multi/blob/master/pipcompilemulti/features/controller.py). Please make sure to...

Thanks for the thorough explanation. This issue seems pretty complex. And I'm not sure I completely understand it. Do you have a good understanding of how the fix would work?