HASS-sonoff-ewelink icon indicating copy to clipboard operation
HASS-sonoff-ewelink copied to clipboard

convert to HACS repo

Open wrboyce opened this issue 5 years ago • 4 comments

wrboyce avatar Dec 14 '19 21:12 wrboyce

hi @wrboyce i'm sorry but just like the other opened PR i'm not looking forward to support more or less automatic updaters, if it works it works if not... there are other options ¯\_(ツ)_/¯

peterbuga avatar Dec 15 '19 10:12 peterbuga

@peterbuga - I truly appreciate your work and your contribution, you made my life much better and I really thank you for that. I fully respect your right about the intent of this repo. On the other hand, I do think that HACS have some advantages to it - when it comes to update fetching and keeping the version latest etc.

I suggest some middle-ground when it comes to that idea: Me, or @wrboyce or someone else - will create a fork of the repo and will work on HACS support, pulling updates frequently from your repo to update.

Any thoughts?

GuyKh avatar Feb 02 '20 07:02 GuyKh

@GuyKh i as well appreciate the offer but i would like to maintain the low-level status of this component (and it's not that widely used... i think)

first of all the component is super basic at it's core and once one gets it to work it rarely needs further updates, 2nd if it's exposed in a simpler way it's highly possible that a lot of people will have problems one way or another and they'll start complaining without providing any logs or decent explanations + possible cross-issues posting on your project and so on (it might easily create a bit of confusion don't you think?)

with all due respect i'm simply not looking for that heat right now, the project has enough install details and there's the easy option to follow the project's progress and that'll make people think twice if they want to update or not (after all, if ain't broke why fix it?) vs. a simple update notification where people will mindlessly click update without reading any release notes.

peterbuga avatar Feb 02 '20 17:02 peterbuga

@peterbuga I completely understand. Furthermore, from the nature of this integration, as you mentioned, an increase of heat and number of users, I'm afraid this could make Sonoff (or eWeLink) to take actions against this integration. Or they maybe would put challenges in the connection to their API.

GuyKh avatar Feb 02 '20 20:02 GuyKh