ical.js icon indicating copy to clipboard operation
ical.js copied to clipboard

Refactor ical, relocating parsing code into new module suitable for non-Node.js environments

Open matthewadams opened this issue 5 years ago • 3 comments

Hi, thanks for the helpful project. I'm having an issue using this in a non-Node.js environment (Google Apps scripting), and there's an easy fix, because this project's i/o features are the only issues:

  1. Move all ical parsing code (parseICS) into a new npm module @peterbraden/ical-parser (scope required because unscoped package ical-parser already exists).
  2. Refactor ical to depend on @peterbraden/ical-parser for the parsing logic, but retain the fromURL and parseFile methods for backward compatibility.

If needed, I have already separated the parsing logic myself, and can give it to you in order for you to create @peterbraden/ical-parser. Just let me know if you want it.

NB: Looks like https://github.com/peterbraden/ical.js/issues/80 is related to this.

matthewadams avatar Sep 22 '19 15:09 matthewadams

Can I suggest an alternate approach? We could drop fromUrl and parseFile - they never should have been part of this module, as they are out of scope.

I'd be happy to release a major version removing these functions.

peterbraden avatar Sep 23 '19 07:09 peterbraden

That would work, for sure, I just thought you'd want to preserve backward compatibility. Your project, do what you want, but just make sure to rev the major version to remain semver compliant. Thanks!

matthewadams avatar Sep 23 '19 15:09 matthewadams

Did this ever get resolved?

rudydelorenzo avatar Mar 17 '22 17:03 rudydelorenzo