peterbell10
peterbell10
I've been trying out [fmt](https://github.com/fmtlib/fmt) and it seems to be really good. I'm curious how important it is to use the `printf` style formatting though. I find the python style...
fmt's python style format strings work very similarly: ``` cpp fmt::format("Some string with placeholders: {0}, {1}, and repeating {0}", "a1", "a2"); ``` I believe by default arguments without placeholders are...
@pytorchbot merge -r
@pytorchbot merge
Unfortunately this still has worse performance than two pass reduction for many of the cases in #120184 but the regression is at least less severe. Here is the result for...
@pytorchbot merge -r
@pytorchbot merge
@kit1980 is it a small bump in test tolerance, or a catastrophic failure in accuracy? A minified program with inputs would be really useful here, otherwise I can't say much.
After rerunning the benchmarks, the perf gain seems to have disappeared, or perhaps was previously dominated by the removal of the first iteration reduction step which was spun out into...
@pytorchbot rebase