Peter Becich

@flip111 , thanks for taking a look at this. > Is it both encoding and decoding that are problematic ? I think the only issue is server-side encoding > then...

The issue is on the Haskell side. Aeson encoding of `Either` is incompatible with Purescript library `argonaut-aeson-generic`. Example: ``` "_fooE": { "Left": "foooo" }, ``` The Purescript library expects to...

The `Either` has a `tag` now. Next issue is missing field `value`. The other datatypes decode fine with `contents`; why does `Either` need to have `value`? ``` Serving JSON: {...

@eskimor, @kindaro, @bentongxyz , please review I have updated the summary: https://github.com/eskimor/purescript-bridge/pull/89#issue-1910635911 IOHK's `RoundTrip` tests are the best check on this PR in my opinion. This are run in CI....

@flip111 it sounds like a good idea to me. I think it is an addition to be done later in a different PR, an additional option to the three existing...

Thanks @kindaro , about formatting, `eskimor/purescript-bridge` is all Stylish Haskell; IOHK uses Ormolu. The repo originally had no consistent format chosen so I decided on Stylish Haskell and @eskimor agreed:...

>  By the way, formatting with fourmolu with the following settings and then with stylish-haskell makes a diff of 814 lines, compared with 4186 lines if ormolu is used, so...

Excellent points, thanks @kindaro , I had not noticed these issues. Thinking about how to fix the `instances`. About the formatting, I'd rather not go back and reformat these commits,...

I agree this should be fixed: https://github.com/eskimor/purescript-bridge/pull/89#issuecomment-1890994859 Here is the easy part of the change: https://github.com/peterbecich/purescript-bridge/commit/e663a3d31c18e9474e0da1818234e01894132dad However, this breaks other things which I haven't had time to look into. The...

@flip111 thank you for the detailed comment, I will read carefully later One thing I need help with is fixing the `generic Show` instance. It was correctly implemented by @kindaro,...