django-cache-memoize icon indicating copy to clipboard operation
django-cache-memoize copied to clipboard

Add default timeout to cache memoize

Open KarimTayie opened this issue 4 years ago • 11 comments

KarimTayie avatar Dec 30 '20 20:12 KarimTayie

Can't you just leave it instead? I.e. if you do:

>>> from django.core.cache import cache
>>> cache.set('foo', 'bar')

it will apply whatever's in django.conf.settings.CACHES["default"].

peterbe avatar Jan 04 '21 20:01 peterbe

Oh I see. I think you can just use:

>>> from django.core.cache import cache
>>> cache.set('foo', 'bar', timeout=object())

is the exact same as not specifying it.

peterbe avatar Jan 04 '21 20:01 peterbe

I can't merge this because the CI tests aren't running. Any idea why?

peterbe avatar Jan 04 '21 20:01 peterbe

Hello, sorry for taking so long to reply.

I can't merge this because the CI tests aren't running. Any idea why?

I can't find the CI tests, can you please show me the logs?

KarimTayie avatar Jan 13 '21 16:01 KarimTayie

Let's see if this restarts the CI tests.

peterbe avatar Jan 20 '21 03:01 peterbe

Can you merge in the latest upstream master into your branch and push. Perhaps that'll pick up the new GitHub Actions checks.

peterbe avatar Jan 20 '21 03:01 peterbe

From github.com:peterbe/django-cache-memoize
 * branch            master     -> FETCH_HEAD
Already up to date.

already pulled the latest upstream master into this pr. Screenshot from 2021-01-21 23-31-46 from this screenshot, all looks good.

KarimTayie avatar Jan 21 '21 21:01 KarimTayie

Let's try if close and re-opening triggers the CI tests.

peterbe avatar Jan 22 '21 13:01 peterbe

What the heck?! I don't know why the tests aren't running. I'll have to take a look some day when I have time.

peterbe avatar Jan 22 '21 16:01 peterbe

@KarimTayie @peterbe my update in #48 should make the tests run via https://github.com/peterbe/django-cache-memoize/pull/48/commits/8470d5ba6feaf10519a5bd2ca360187fde726d7e

YPCrumble avatar Mar 27 '21 20:03 YPCrumble

@KarimTayie can you merge in master into your branch and push that that should hopefully fix your tests.

peterbe avatar Mar 29 '21 14:03 peterbe