Peter Argue

Results 113 comments of Peter Argue

@Guitarheroua can you take a look at the compiler errors and conflict?

@janezpodhostnik looks like the missing dependencies are from the `GetTransactionExecutionMetricsAfter` endpoint. Is that OK to backport to v0.37?

@zhangchiqing there are 3 PRs. I updated the description with the list

Looks great @Guitarheroua. A few comments: * I think the subscribe/unsubscribe needs an ID field to uniquely identify a subscription on a topic that could have multiple instances (e.g. events,...

Thanks for the updates. I think we can consolidate the endpoints a bit. With grpc, we get some input validation for free. Since we don't get that with websockets, I...

> Subscription Tracking: The broker should track active subscriptions by topic and subscription ID, ensuring it does not subscribe to the same topic more than once under the same connection....

I made a bunch of changes before looking into this PR, so had to make the changes by hand. added in [b1d7688](https://github.com/onflow/flow-go/pull/7523/commits/b1d76880ac23b6c9c22ee16457d622efca2576ab)

@illia-malachyn looks good. please merge master

@illia-malachyn to get this PR ready to merge please: 1. merge master and fix conflicts 2. remove the `replace` statement for the core contracts repo, and update to use `v1.3.1`...